-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy pool booster on Sonic #2415
Open
sparrowDom
wants to merge
3
commits into
master
Choose a base branch
from
sparrowDom/sonic_deploy_10
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clement-ux
reviewed
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- PoolBoostCentralRegistryProxy
- PoolBoostCentralRegistry
- PoolBoosterFactorySwapxDouble
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- PoolBoostCentralRegistryProxy: No constructor
- PoolBoostCentralRegistry: No constructor
- PoolBoosterFactorySwapxDouble:
- _oSonic ✅
- _governor ✅
- _centralRegistry ✅
- The transactions that interacted with the newly deployed contract match the deploy script.
- Initialize Proxy ✅
Soon:
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Diff checker
- PoolBoostCentralRegistryProxy
sol2uml diff 0x4F3B656Aa5Fb5E708bF7B63D6ff71623eb4a218A .,node_modules -n sonic
(node:3390) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "PoolBoostCentralRegistryProxy" contract with address 0x4F3B656Aa5Fb5E708bF7B63D6ff71623eb4a218A on sonic
to local files under folders ".,node_modules"
match @openzeppelin/contracts/utils/Address.sol
match contracts/governance/Governable.sol
match contracts/proxies/InitializeGovernedUpgradeabilityProxy.sol
match contracts/proxies/Proxies.sol
- PoolBoostCentralRegistry
sol2uml diff 0x246594d0276ffAeB0442c3edcdfB026e6924B3B3 .,node_modules -n sonic
(node:3494) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "PoolBoostCentralRegistry" contract with address 0x246594d0276ffAeB0442c3edcdfB026e6924B3B3 on sonic
to local files under folders ".,node_modules"
match contracts/governance/Governable.sol
match contracts/interfaces/poolBooster/IPoolBoostCentralRegistry.sol
match contracts/poolBooster/PoolBoostCentralRegistry.sol
- PoolBoosterFactorySwapxDouble
sol2uml diff 0x840081c97256d553A8F234D469D797B9535a3B49 .,node_modules -n sonic
(node:3541) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
Compared the "PoolBoosterFactorySwapxDouble" contract with address 0x840081c97256d553A8F234D469D797B9535a3B49 on sonic
to local files under folders ".,node_modules"
match @openzeppelin/contracts/token/ERC20/IERC20.sol
match @openzeppelin/contracts/utils/math/SafeMath.sol
match contracts/governance/Governable.sol
match contracts/interfaces/poolBooster/IPoolBoostCentralRegistry.sol
match contracts/interfaces/poolBooster/IPoolBooster.sol
match contracts/interfaces/poolBooster/ISwapXAlgebraBribe.sol
match contracts/poolBooster/AbstractPoolBoosterFactory.sol
match contracts/poolBooster/PoolBoosterFactorySwapxDouble.sol
match contracts/poolBooster/PoolBoosterSwapxDouble.sol
match contracts/utils/StableMath.sol
shahthepro
approved these changes
Feb 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- All deployed contracts are listed in the deploy PR's description
- Deployed contract's verified code (and all dependencies) match the code in master
- Contract constructors have correct arguments
- The transactions that interacted with the newly deployed contract match the deploy script.
- Governance proposal matches the deploy script
- Smoke tests pass after fork test execution of the governance proposal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contract Deployment
Governance
Check files under
contracts/deployments/base/operations
for the generated JSON files.Actions:
Deploy checklist
Two reviewers complete the following checklist: