Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sonic SwapX AMO Strategy #2407

Draft
wants to merge 5 commits into
base: nicka/sonic-curve-amo
Choose a base branch
from

Conversation

naddison36
Copy link
Collaborator

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Copy link

github-actions bot commented Feb 20, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 11815d2

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 158 lines in your changes missing coverage. Please review.

Project coverage is 48.14%. Comparing base (f2766ed) to head (11815d2).

Files with missing lines Patch % Lines
...ntracts/strategies/sonic/SonicSwapXAMOStrategy.sol 0.00% 158 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f2766ed) and HEAD (11815d2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f2766ed) HEAD (11815d2)
2 1
Additional details and impacted files
@@                    Coverage Diff                    @@
##           nicka/sonic-curve-amo    #2407      +/-   ##
=========================================================
- Coverage                  53.39%   48.14%   -5.26%     
=========================================================
  Files                         96       97       +1     
  Lines                       4723     4881     +158     
  Branches                    1252     1299      +47     
=========================================================
- Hits                        2522     2350     -172     
- Misses                      2197     2527     +330     
  Partials                       4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant