Curve Pool Booster for L2 #2389
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2389 +/- ##
==========================================
- Coverage 50.96% 50.60% -0.36%
==========================================
Files 92 93 +1
Lines 4529 4592 +63
Branches 1203 1223 +20
==========================================
+ Hits 2308 2324 +16
- Misses 2217 2264 +47
Partials 4 4 ☔ View full report in Codecov by Sentry. |
shahthepro
reviewed
Feb 11, 2025
| /// @title CurvePoolBooster | ||
| /// @author Origin Protocol | ||
| /// @notice Contract to manage interactions with VotemarketV2 for a dedicated Curve pool/gauge. | ||
| contract CurvePoolBoosterDirect is Initializable, Strategizable { |
There was a problem hiding this comment.
nit: we should probably move these contracts into their own directories. They're not Vault strategies, so don't really belong here
There was a problem hiding this comment.
Any suggestion for the the directory name?
There was a problem hiding this comment.
I ain't sure. But since we are naming the contracts "PoolBooster", we can probably use the same as the name of the directory as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
CurvePoolBooster(CPB) has been deployed and works for gauge that are on Ethereum mainnet. AsVotemarketis only deployed on L2s, CPB used theCampaignRemoteManagercontract to interact withVotemarketon L2 and create/manage bribes.But for gauge that are already on L2, it will be more efficient to directly use the Votemarket on L2, no need to bridge message!
So this implementation of CPB is a simplified version that directly interact with Votemarket.
Code Change Checklist
To be completed before internal review begins:
Internal review: