Fixes 35 - PDF custom weapon display bug #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subscribed `all-weapons-map` so custom data is up to date * Added documentation and comments for future maintainers
Jessomadic
approved these changes
Mar 23, 2024
datdamnzotz
dismissed
Jessomadic’s stale review
The merge-base changed after approval.
datdamnzotz
requested changes
Mar 28, 2024
There was a problem hiding this comment.
Pull the rod-of-asclepius.svg from this commit and the other changes.
Other than that looks good
codeGlaze
dismissed
datdamnzotz’s stale review
The merge-base changed after approval.
datdamnzotz
previously approved these changes
Mar 28, 2024
|
n/m the image was already in there from a prior commit (missed that, thats on me) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Subscribed the
all-weapons-mapto stay up to date via re-frame . . . bug squashed!Related issue: fixes #35
Checklist: