Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Doc Links #17316

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Fix Broken Doc Links #17316

merged 4 commits into from
Jan 7, 2025

Conversation

jbytes1027
Copy link
Contributor

@jbytes1027 jbytes1027 commented Jan 7, 2025

Fix #17303

  • Add doc redirects for b3ac8fa changes
  • Fix various doc links missed in b3ac8fa

@jbytes1027 jbytes1027 changed the title FixBrokenDocLinks Fix Broken Doc Links Jan 7, 2025
@jbytes1027
Copy link
Contributor Author

jbytes1027 commented Jan 7, 2025

The views have translations for the view links that are now probably broken. They are in the gitigore and I'm not sure how they work so I didn't update them.

@Piedone
Copy link
Member

Piedone commented Jan 7, 2025

The views have translations for the view links that are now probably broken. They are in the gitigore and I'm not sure how they work so I didn't update them.

What are you referring to, exactly?

@jbytes1027
Copy link
Contributor Author

View files lines that I changed like this:

src/OrchardCore.Modules/OrchardCore.ContentFields/Views/HtmlFieldSettings.Edit.cshtml:
    <a class="seedoc" href="@(OrchardCore.Admin.Constants.DocsUrl)reference/modules/Sanitizer" target="_blank">@T["See documentation"]</a>

Have corresponding lines in po localization files:

src/OrchardCore.Cms.Web/Localization/zh-Hant/OrchardCore.Menu.po:
    <a class="seedoc" href="@(OrchardCore.Admin.Constants.DocsUrl)reference/modules/Sanitizer" target="_blank">@T["See documentation"]</a>

The po files had the old links. Not sure when they were regenerated or how, but they're updated now, at least on my local machine.

@Piedone
Copy link
Member

Piedone commented Jan 7, 2025

Ah OK. Yes, they'll be regenerated, and now the old links will work too.

@Piedone Piedone merged commit 022aaf9 into OrchardCMS:main Jan 7, 2025
13 checks passed
@jbytes1027 jbytes1027 deleted the FixBrokenDocLinks branch January 7, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue bot links outdated
2 participants