Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing GitHub Actions workflows Ubuntu 24 incompatibility (Lombiq Technologies: OCORE-219) #17313

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Fixing GitHub Actions workflows Ubuntu 24 incompatibility (Lombiq Technologies: OCORE-219) #17313

wants to merge 17 commits into from
+57 −68

Conversation

Piedone
Copy link
Member

@Piedone Piedone commented Jan 6, 2025 •
edited
Loading

Fix #17311.

  • Configured the workflows to use Ubuntu 24 explicitly, so we prevent future surprise updates like this. In the future, Renovate will take care of this.
  • Configured the Windows workflows to run an explicit version of Windows (the current 2022) too for the same reason.
  • Factored out the actions/setup-dotnet call to an internal action, so it's easier to update. Also fixed the unit tests with that.
  • Done test runs with Functional Tests - All Databases and Unit Tests - MacOS too.

Before merge the branch protection ruleset needs to be updated to require the ubuntu-24.04 and windows-2022 status checks.

@Piedone Piedone marked this pull request as ready for review January 6, 2025 17:02
@Piedone Piedone requested a review from sebastienros January 7, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebastienros sebastienros sebastienros approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GitHub Actions workflows fail due to Ubuntu 24
2 participants
@Piedone @sebastienros