Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue bot links outdated #17303

Closed
jbytes1027 opened this issue Jan 5, 2025 · 5 comments · Fixed by #17316
Closed

Issue bot links outdated #17303

jbytes1027 opened this issue Jan 5, 2025 · 5 comments · Fixed by #17316
Labels
bug 🐛 good first issue

Comments

@jbytes1027
Copy link
Contributor

The doc links in this GH bot are broken/outdated.

image

We triaged this issue and set the milestone according to the priority we think is appropriate (see the docs on how we triage and prioritize issues).

This indicates when the core team may start working on it. However, if you'd like to contribute, we'd warmly welcome you to do that anytime. See our guide on contributions here.
@hishamco
Copy link
Member

hishamco commented Jan 5, 2025

/cc @Piedone

@Piedone
Copy link
Member

Piedone commented Jan 5, 2025

Would you like to open a PR for fixing this? The current links are https://docs.orchardcore.net/en/latest/contributing/managing-issues/ and https://docs.orchardcore.net/en/latest/contributing/. And at the same time, under redirect_maps in mkdocs.yml, you can make the old links work too.

@jbytes1027
Copy link
Contributor Author

Yea I can fix this. I didn't realize I could edit the bot.

@Piedone
Copy link
Member

Piedone commented Jan 5, 2025

Great! Yep, it's a GitHub Actions workflow: https://github.com/OrchardCMS/OrchardCore/blob/main/.github/workflows/comment_issue_on_triage.yml

@Piedone
Copy link
Member

Piedone commented Jan 5, 2025

Actually, I see that you moved a lot of pages around under #17213. For each of these, please also add redirects in redirect_maps, because now a lot of external links are broken.

@jbytes1027 jbytes1027 mentioned this issue Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Broken Doc Links jbytes1027/OrchardCore
3 participants
@Piedone @hishamco @jbytes1027