Fixes for terraform component types #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocktavious
commented
Jan 31, 2025
| @@ -14,6 +16,40 @@ type ComponentTypeConnection struct { | |||
| TotalCount int `json:"totalCount" graphql:"-"` | |||
| } | |||
|
|
|||
| func (s *ComponentType) GetProperties(client *Client, v *PayloadVariables) (*PropertyDefinitionConnection, error) { | |||
There was a problem hiding this comment.
This is the pattern we use for connection types because it limits how much data we pull back when doing "list" api calls.
rocktavious
commented
Jan 31, 2025
| IsDefault bool // Whether or not the component type is the default (Required) | ||
| Name string // The name of the component type (Required) | ||
| Timestamps Timestamps // When the component type was created and updated (Required) | ||
| Properties *PropertyDefinitionConnection `graphql:"-"` |
There was a problem hiding this comment.
This will get to get ported into codegen but this effectively tells the graphql client to ingore this field since we'll populate it with GetProperties when called
rocktavious
commented
Jan 31, 2025
| @@ -13,7 +13,7 @@ type PropertyDefinition struct { | |||
| DisplayType PropertyDefinitionDisplayTypeEnum `graphql:"displayType" json:"displayType"` | |||
| PropertyDisplayStatus PropertyDisplayStatusEnum `graphql:"propertyDisplayStatus" json:"propertyDisplayStatus"` | |||
| LockedStatus PropertyLockedStatusEnum `graphql:"lockedStatus" json:"lockedStatus"` | |||
| Schema JSON `json:"schema" scalar:"true"` | |||
| Schema JSONSchema `json:"schema" scalar:"true"` | |||
There was a problem hiding this comment.
Not sure why it was coded like this but in our API its actually this type (this struct isn't under codegen yet)
p25marti
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
Connection types were not setup by codegen so this was missed
Solution
Add connection type for property def's on component types
Checklist