Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add definition for LockedStatus #514

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Add definition for LockedStatus #514

merged 2 commits into from
Jan 31, 2025

Conversation

p25marti
Copy link
Contributor

@p25marti p25marti commented Jan 30, 2025 •
edited
Loading

Problem

Adds LockedStatus to the PropertyDefinition struct so that we can use it downstream in our tooling.

Solution

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Does this change require a Terraform schema change?
    • If so what is the ticket or PR #
  • Make a changie entry that explains the customer facing outcome of this change

@p25marti p25marti force-pushed the p25marti/add-locked-status-field branch from 151a756 to 087901d Compare January 31, 2025 14:18
@p25marti p25marti force-pushed the p25marti/add-locked-status-field branch from 087901d to f5d0a5c Compare January 31, 2025 14:19
@p25marti p25marti changed the title P25marti/add locked status field Add definition for LockedStatus Jan 31, 2025
@p25marti p25marti marked this pull request as ready for review January 31, 2025 15:56
@p25marti p25marti requested a review from rocktavious January 31, 2025 15:56
rocktavious
rocktavious approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@rocktavious rocktavious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work! Sorry for all the getting started bumps

@p25marti p25marti merged commit 250d418 into main Jan 31, 2025
4 checks passed
@p25marti p25marti deleted the p25marti/add-locked-status-field branch January 31, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rocktavious rocktavious rocktavious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p25marti @rocktavious