Codegen Payload Types #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocktavious
commented
Jan 29, 2025
| @@ -56,7 +56,7 @@ type CustomActionsTriggerDefinitionsConnection struct { | |||
|
|
|||
| func (client *Client) CreateWebhookAction(input CustomActionsWebhookActionCreateInput) (*CustomActionsExternalAction, error) { | |||
| var m struct { | |||
| Payload struct { | |||
| Payload struct { // TODO: fix this | |||
There was a problem hiding this comment.
All the "TODO" are there for future self's when we come back around. Unfortunately switching these inline structs to the generated payload stucts requires test changes that i'm not willing to take on right now. So i've just noted all the places where we need to fix for the future.
p25marti
approved these changes
Jan 29, 2025
rocktavious
added a commit
that referenced
this pull request
Jan 30, 2025
* Add component CRUD functions * small fixes * Codegen Payload Types (#512) * Codegen Payload Types * lint fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
Payload types are hand crafted per mutation
Solution
codegenerate them
Checklist