Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add component CRUD functions #511

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Add component CRUD functions #511

merged 3 commits into from
Jan 30, 2025

Conversation

rocktavious
Copy link
Collaborator

Resolves #

Problem

Its confusing to use the CRUD methods for service to create components

Solution

We want to make it a little nicer for end users to know there are CRUD components but in the end they just federate out to the old services APIs for now. This will give us a future handle to redirect them to newer APIs as needed.

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Does this change require a Terraform schema change?
    • If so what is the ticket or PR #
  • Make a changie entry that explains the customer facing outcome of this change

@rocktavious rocktavious requested a review from p25marti January 28, 2025 21:47
@rocktavious rocktavious self-assigned this Jan 28, 2025
@@ -376,6 +376,14 @@ func (client *Client) GetService(id ID) (*Service, error) {
return &q.Account.Service, nil
}

func (client *Client) GetService(identifier string) (*Service, error) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've been meaning to do this for a LONG time and with the 2025 release emmient - now is a good time to pull the trigger on this breaking change.

For opslevel-go using customers they won't automatically upgrade to this version so it won't break them because the v2025 release is like a "major" version change. So they'll have to explicitly upgrade and even then the go compiler should catch most of these changes

* Codegen Payload Types

* lint fixes
@rocktavious rocktavious merged commit c5fbf99 into main Jan 30, 2025
4 checks passed
@rocktavious rocktavious deleted the kr/components-crud branch January 30, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants