Code Gen v2 #509
Merged
Code Gen v2 #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocktavious
commented
Jan 27, 2025
| @@ -100,7 +78,7 @@ func (client *Client) GetCustomAction(input string) (*CustomActionsExternalActio | |||
| "input": *NewIdentifier(input), | |||
| } | |||
| err := client.Query(&q, v, WithName("ExternalActionGet")) | |||
| if q.Account.Action.Id == "" { | |||
| if q.Account.Action.CustomActionsId.Id == "" { | |||
There was a problem hiding this comment.
This needs to be investigated to see if we can fix this
* generate Go structs of graphql API objects * temp limit objects generated, add mapping for field types * generate first objects, update tests * generate most objects starting with A-C, update tests
* generate unions * drop unused TagOwner enums * union tpl clean up
rocktavious
force-pushed
the
feature/gen-code
branch
from
2de9d4c to
a87c4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
Prior to this a large chunk of the opslevel-go codebase was hand curated. This is untenniable long term especially when graphql is a schema based API.
Solution
Finish out the code gen so the entire client library is generated. (or at least as much as possible)
Checklist