Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First pass of implementation for Aliasable Resources #483

Merged
merged 10 commits into from
Oct 22, 2024
Merged

First pass of implementation for Aliasable Resources #483

merged 10 commits into from
Oct 22, 2024

Conversation

rocktavious
Copy link
Collaborator

@rocktavious rocktavious commented Oct 21, 2024 •
edited
Loading

Resolves https://github.com/OpsLevel/team-platform/issues/496

TODO: Finish Tests

Problem

Currently we have no unified way to handle Aliasable resources like we do for Taggable ones.

Solution

Apply the same interface pattern that was done to Taggable resources but for Aliasable ones.

Checklist

  • I have run this code, and it appears to resolve the stated issue.
  • This PR does not reduce total test coverage
  • This PR has no user interface changes or has already received approval from product management to change the interface.
  • Does this change require a Terraform schema change?
    • If so what is the ticket or PR # TBD
  • Make a changie entry that explains the customer facing outcome of this change

@rocktavious rocktavious self-assigned this Oct 21, 2024
rocktavious
rocktavious commented Oct 21, 2024
View reviewed changes
aliases.go Show resolved Hide resolved
rocktavious
rocktavious commented Oct 21, 2024
View reviewed changes
aliases_test.go Outdated Show resolved Hide resolved
davidbloss
davidbloss reviewed Oct 21, 2024
View reviewed changes
aliases.go Outdated Show resolved Hide resolved
rocktavious
rocktavious commented Oct 21, 2024
View reviewed changes
tags.go Show resolved Hide resolved
rocktavious
rocktavious commented Oct 21, 2024
View reviewed changes
team.go Outdated Show resolved Hide resolved
davidbloss
davidbloss approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@davidbloss davidbloss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@rocktavious rocktavious merged commit 1693731 into main Oct 22, 2024
4 checks passed
@rocktavious rocktavious deleted the kr/aliasable branch October 22, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbloss davidbloss davidbloss approved these changes

Assignees

@rocktavious rocktavious

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rocktavious @davidbloss