add regionOverride field to AWS integration, for overriding multiple regions #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 7, 2024
rocktavious
reviewed
Oct 9, 2024
| @@ -53,11 +54,12 @@ type IntegrationConnection struct { | |||
| } | |||
|
|
|||
| type AWSIntegrationInput struct { | |||
There was a problem hiding this comment.
It seems this struct is duplicative of whats in input.go ? why?
There was a problem hiding this comment.
Yeah I noticed that... not sure what happened here but didn't want to yank out the duplicate before figuring out which is the "good" one
There was a problem hiding this comment.
Lets make sure we follow this up
rocktavious
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #505
Problem
Solution
Checklist