New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CodeIssue check type #470

Merged

davidbloss merged 8 commits into main from db/code-issue-check

Oct 24, 2024

Contributor

davidbloss commented Oct 4, 2024

Resolves #504

Added CodeIssue check and update check tests to be more robust

Problem

Solution

Checklist

I have run this code, and it appears to resolve the stated issue.
This PR does not reduce total test coverage
This PR has no user interface changes or has already received approval from product management to change the interface.
Does this change require a Terraform schema change?
- If so what is the ticket or PR #
Make a changie entry that explains the customer facing outcome of this change

davidbloss added 2 commits

October 4, 2024 12:33


          add CodeIssue check type, more robust check testing

df36783


          remove redundant assertions in check test

8c1d1e8

davidbloss requested a review from rocktavious

October 4, 2024 17:36

davidbloss self-assigned this

rocktavious reviewed

View reviewed changes

check_code_issue.go Outdated Show resolved Hide resolved

rocktavious reviewed

View reviewed changes

input.go Outdated Show resolved Hide resolved

rocktavious reviewed

View reviewed changes

input.go Outdated Show resolved Hide resolved

rocktavious reviewed

View reviewed changes

input.go Outdated Show resolved Hide resolved

rocktavious reviewed

View reviewed changes

check_code_issue.go Outdated Show resolved Hide resolved

rocktavious requested changes

View reviewed changes

Collaborator

rocktavious left a comment

Lots of issues with this one. Let me know if you want to sit down and chat through it.


          Merge branch 'main' into db/code-issue-check

6dddaef

davidbloss marked this pull request as draft

October 11, 2024 19:56


          add CodeIssueCheckFragment, update struct docs and tests

ca54621

davidbloss marked this pull request as ready for review

October 18, 2024 16:17


          fix types of fields in CodeIssueCheck

d57d1f0

rocktavious reviewed

View reviewed changes

check_test.go Outdated

+              				"severity":       []string{"sev1", "sev2"},
+              			}),
+              		},
+              		"UpdateCodeIssue": {

Collaborator

rocktavious Oct 18, 2024

I think we'll want to throw a few more "update" test cases in here to ensure it generates the right input for a few of these optional fields. maxAllowed, resolutionTime etc etc

rocktavious approved these changes

View reviewed changes

Collaborator

rocktavious left a comment •

edited

Loading

If the extra tests are too tricky to write correctly because of API validation - then this is 👍

davidbloss added 2 commits

October 22, 2024 13:23


          Merge branch 'main' into db/code-issue-check

f04970c


          add CodeIssueCheck structs and tests

ae62e1b

davidbloss changed the title ~~add CodeIssue check type, more robust check testing~~ add CodeIssue check type

rocktavious reviewed

View reviewed changes

check_code_issue.go Outdated Show resolved Hide resolved


          remove unneeded pointers

c70b67e

rocktavious approved these changes

View reviewed changes

Collaborator

rocktavious left a comment

Heafty but good work!!

davidbloss merged commit b7f5d59 into main

4 checks passed

davidbloss deleted the db/code-issue-check branch

October 24, 2024 19:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet