Fix handling string containing object for NewJSONInput and use table tests for JSON

[taimoorgit]

Issues

Part of: OpsLevel/kubectl-opslevel#244 / https://github.com/OpsLevel/product/issues/8

Changelog

• NewJSONInput will stop adding extra backslashes to unnecessarily escape "{\"foo\": \"bar\"}". This is the only functional change.
• Use table tests for all constructors (NewJSONInput, NewJSON, NewJSONSchema)
• Add documentation for the 3 constructors and types
• Make a changie entry

Before/after

Before I had to make this change in k8s sync in order for syncing object/array properties that are defined in .metadata.annotations (handled as a string):

		// TODO: hack to get around NewJSONInput not reading strings properly.
		var value opslevel.JsonString
		if strings.HasPrefix(val, "{") && strings.HasSuffix(val, "}") {
			value = opslevel.JsonString(val)
		} else {
			valuePtr, err := opslevel.NewJSONInput(val)
			if err != nil {
				log.Error().Err(err).Msgf("[%s] Failed parsing property: '%s'", service.Name, def)
				continue
			}
			value = *valuePtr
		}

This if clause is no longer necessary.

[taimoorgit]

Removed because all these equals checks are done by reflect.DeepEqual anyways, which is what autopilot.Equals is doing.

[taimoorgit]

Removed the "age":45, here because it is annoying to have reflect.DeepEqual fail to compare a int to a float64. This is handled by JSON marshal, we don't get any benefits from testing this on our own. We just need to make sure that keys and values are not being discarded.

[davidbloss]

LGTM! 🎉