add struct util functions and default struct tags #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #331 +/- ##
==========================================
- Coverage 77.10% 76.89% -0.21%
==========================================
Files 52 52
Lines 3389 3406 +17
==========================================
+ Hits 2613 2619 +6
- Misses 568 578 +10
- Partials 208 209 +1 ☔ View full report in Codecov by Sentry. |
davidbloss
changed the title
rocktavious
reviewed
Dec 12, 2023
| @@ -9,19 +9,15 @@ import ( | |||
|
|
|||
| func TestCreateTool(t *testing.T) { | |||
| // Arrange | |||
| toolCreateInput := autopilot.Register[ol.ToolCreateInput]("tool_create_input", ol.NewExampleOf[ol.ToolCreateInput]()) | |||
rocktavious
reviewed
Dec 12, 2023
utils.go
Outdated
| var structValidator = validator.New(validator.WithRequiredStructEnabled()) | ||
|
|
||
| // Validates resource's `validate:""` struct tags | ||
| func IsResourceValidate[T any](opslevelResource T) error { |
There was a problem hiding this comment.
These function names are 😍 - Great Job! This one maybe should be IsResourceValid ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Changelog
Add
default:""struct tags to:MemberInput,PropertyDefinitionInput,ToolCreateInput,ToolUpdateInput,UserInput,UserIdentifierInputAdd
utils.gowith these functions:IsResourceValidate[T any](opslevelResource T)- validates structs based onvalidate:""struct tagsSetDefaultsFor[T any](opslevelResource *T)- sets defaults defined bydefault:""struct tagsNewExampleOf[T any]()- generic constructor that sets defaults defined bydefault:""struct tagsJsonOf[T any](opslevelResource T)- converts struct to JSON formatted stringYamlOf[T any](opslevelResource T)- converts struct to Yaml formatted stringIsResourceValidateis not yet usedchangieentryTophatting
task test- tests pass