Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finish moving last of json testdata to use BestTestClient #309

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

davidbloss
Copy link
Contributor

@davidbloss davidbloss commented Nov 15, 2023

Issues

#128

Changelog

Delete the rest of the testdata/fixtures/**/*.json files 🎉

  • The data lives with each test now. In time these will be routed through autopilot.Register[]() and we'll have a sleek, unified way of testing

  • List your changes here

  • [] Make a changie entry, N/A test data

Tophatting

task test - tests pass

@davidbloss davidbloss requested review from rocktavious and a user November 15, 2023 21:06
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6e22c7d) 76.75% compared to head (27b8041) 76.75%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #309   +/-   ##
=======================================
  Coverage   76.75%   76.75%           
=======================================
  Files          50       50           
  Lines        3308     3308           
=======================================
  Hits         2539     2539           
  Misses        565      565           
  Partials      204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You dropped this: 👑

@davidbloss davidbloss merged commit 6259036 into main Nov 15, 2023
5 checks passed
@davidbloss davidbloss deleted the db/update-table-tested-checks branch November 15, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants