Support for Property Definitions #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbloss
reviewed
Nov 15, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
==========================================
+ Coverage 76.90% 77.21% +0.31%
==========================================
Files 50 51 +1
Lines 3338 3384 +46
==========================================
+ Hits 2567 2613 +46
+ Misses 566 563 -3
- Partials 205 208 +3 ☔ View full report in Codecov by Sentry. |
rocktavious
reviewed
Nov 15, 2023
rocktavious
reviewed
Nov 15, 2023
rocktavious
reviewed
Nov 15, 2023
rocktavious
reviewed
Nov 15, 2023
rocktavious
requested changes
Nov 15, 2023
davidbloss
reviewed
Nov 20, 2023
ghost
commented
Nov 23, 2023
davidbloss
reviewed
Nov 28, 2023
davidbloss
reviewed
Nov 28, 2023
ghost
force-pushed
the
service-props
branch
2 times, most recently
from
570217a to
afea0f2
Compare
davidbloss
reviewed
Dec 7, 2023
rocktavious
reviewed
Dec 7, 2023
Co-authored-by: Kyle <[email protected]>
Co-authored-by: David Bloss <[email protected]>
Co-authored-by: David Bloss <[email protected]>
Co-authored-by: David Bloss <[email protected]>
ghost
mentioned this pull request
3 tasks
…a-field-to-jsonstring make PropertyDefinition.Schema field a JSONString type, update tests
rocktavious
reviewed
Dec 8, 2023
| Aliases []string `graphql:"aliases" json:"aliases"` | ||
| Id ID `graphql:"id" json:"id"` | ||
| Name string `graphql:"name" json:"name"` | ||
| Schema JSON `json:"schema" scalar:"true"` // Do not add graphql struct tag here |
There was a problem hiding this comment.
well you can add graphql struct tags if you neeed - you actually just need scalar:"true" because JSON is a custom scalar type we wrote.
rocktavious
approved these changes
Dec 8, 2023
davidbloss
added a commit
that referenced
this pull request
Dec 14, 2023
support for property definitions --- Co-authored-by: Rocktavious <[email protected]> Co-authored-by: Kyle <[email protected]> Co-authored-by: David Bloss <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
https://github.com/OpsLevel/team-platform/issues/122
Relies on #317
Changelog
JSONStringchangieentryTophatting
Tests should pass.