Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert most old test data to new testing style #307

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

davidbloss
Copy link
Contributor

Issues

#128

Changelog

Move most test data from testdata/fixtures/**/*(request|response).json into NewTestRequest() arguments.
💥 Deleted 50 old testdata json files ✌️

  • List your changes here
  • Make a changie entry, N/A testing only

Tophatting

task test - all tests pass

@davidbloss davidbloss requested review from rocktavious and a user November 15, 2023 18:18
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b81d606) 76.80% compared to head (244a9c1) 76.75%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   76.80%   76.75%   -0.06%     
==========================================
  Files          50       50              
  Lines        3307     3308       +1     
==========================================
- Hits         2540     2539       -1     
- Misses        564      565       +1     
- Partials      203      204       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidbloss davidbloss merged commit 6e22c7d into main Nov 15, 2023
@davidbloss davidbloss deleted the db/convert-most-old-test-data-to-new-testing-style branch November 15, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant