add error check to JSON unmarshal, ci fails if linting fails #306
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Changelog
Removed
.golangci.yml
file - this was disabling some error checkingCheck for errors on
json.Unmarshall()
NewTestRequest()
vets test data and verifies it's working with valid JSON. Checking for JSON errors is now a safe move.task lint
now returns a non-zero return code so we can enforce this in CIchangie
entryTophatting
task test
- tests pass