Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error check to JSON unmarshal, ci fails if linting fails #306

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

davidbloss
Copy link
Contributor

Issues

Changelog

Removed .golangci.yml file - this was disabling some error checking
Check for errors on json.Unmarshall()

  • NewTestRequest() vets test data and verifies it's working with valid JSON. Checking for JSON errors is now a safe move.

task lint now returns a non-zero return code so we can enforce this in CI

  • List your changes here
  • Make a changie entry

Tophatting

task test - tests pass

@davidbloss davidbloss requested review from rocktavious and a user November 15, 2023 16:47
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b81d606) 76.80% compared to head (ca8bf15) 76.75%.

Files Patch % Lines
json.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   76.80%   76.75%   -0.06%     
==========================================
  Files          50       50              
  Lines        3307     3308       +1     
==========================================
- Hits         2540     2539       -1     
- Misses        564      565       +1     
- Partials      203      204       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidbloss davidbloss merged commit 56f16ef into main Nov 15, 2023
@davidbloss davidbloss deleted the db/enforce-linting-in-ci branch November 15, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants