update IdentifierInput struct fields to be pointers and usage of struct #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Nov 13, 2023
| Key2 ol.IdentifierInput `json:"key2,omitempty"` | ||
| Key3 *ol.IdentifierInput `json:"key3"` | ||
| Key4 *ol.IdentifierInput `json:"key4,omitempty"` | ||
| IdInputConcrete ol.IdentifierInput `json:"idInputConcrete"` |
There was a problem hiding this comment.
really like this naming change for the field! makes the tests easier to understand.
There was a problem hiding this comment.
💯
Thanks and I couldn't agree more! 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#145
Changelog
BREAKING CHANGE:
Update
IdentifierInputstruct fields to be pointers.IdentifierInputs are core to this code and it's safe to assume this necessary change will cause downstream issues.In most cases this is a simple fix.
dereference the field to get the underlying string
cast a dereferenced
opslevel.IDas a string, e.g.,input.Id,-->string(*input.Id)List your changes here
Make a
changieentryTophatting
task test- all tests pass