make UserIdentifierInput fields pointers #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #301 +/- ##
=======================================
Coverage 76.75% 76.75%
=======================================
Files 49 49
Lines 3299 3299
=======================================
Hits 2532 2532
Misses 564 564
Partials 203 203
|
rocktavious
reviewed
Nov 10, 2023
| @@ -797,7 +797,7 @@ func TestTeamAddMemberhip(t *testing.T) { | |||
| team, _ := clientWithAlias.GetTeamWithAlias("example") | |||
| newMembership := ol.TeamMembershipUserInput{ | |||
| Role: "user", | |||
| User: ol.UserIdentifierInput{Id: id1, Email: "[email protected]"}, | |||
| User: ol.UserIdentifierInput{Id: &id1, Email: ol.NewString("[email protected]")}, | |||
There was a problem hiding this comment.
I "think" this should probably actually be using NewUserIdentifier("[email protected]") - One thing i've been reading up about with idomatic go is that we should really push to use "constructors" for all our types so we can present better interfaces to "setup" objects and then also have a handle to do things like what we do in NewUserIdentifier where we convert the "string" of e-mail into a *string
There was a problem hiding this comment.
Introducing NewUserIdentifier() here would make the line read as:
User: NewUserIdentifier("[email protected]"),
but then we are getting a UserIdentifier without an Id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#145 - partial fix
Changelog
Make
UserIdentifierInputfields pointers to enable expectedomitemptyjson tag behaviorchangieentryTophatting
task test- all tests pass