Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db/remove entity owner struct #300

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

davidbloss
Copy link
Contributor

Issues

#139

Changelog

Remove EntityOwner struct, replaced with TeamId. Updated tests accordingly

  • List your changes here
  • Make a changie entry

Tophatting

task test - all tests pass

@davidbloss davidbloss requested review from rocktavious and a user November 10, 2023 18:26
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Merging #300 (9ddae81) into main (41ec163) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
- Coverage   76.80%   76.75%   -0.06%     
==========================================
  Files          50       49       -1     
  Lines        3307     3299       -8     
==========================================
- Hits         2540     2532       -8     
  Misses        564      564              
  Partials      203      203              
Files Coverage Δ
domain.go 81.35% <ø> (ø)
infra.go 79.84% <ø> (ø)
scorecards.go 90.16% <ø> (ø)
system.go 81.35% <ø> (ø)

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful change 👍

@davidbloss davidbloss merged commit 081e76b into main Nov 10, 2023
5 checks passed
@davidbloss davidbloss deleted the db/remove-entity-owner-struct branch November 10, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant