Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start of consolidating pagination template data #297

Closed
wants to merge 2 commits into from

Conversation

davidbloss
Copy link
Contributor

Issues

#109

Changelog

Preview of where I was heading with generating test data via structs passed into templates.

  • List your changes here
  • Make a changie entry, N/A test data

Tophatting

@davidbloss davidbloss requested review from rocktavious and a user November 9, 2023 17:23
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #297 (7d3afc9) into main (146302d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   76.80%   76.79%   -0.02%     
==========================================
  Files          50       50              
  Lines        3307     3305       -2     
==========================================
- Hits         2540     2538       -2     
  Misses        564      564              
  Partials      203      203              
Files Coverage Δ
clientGQL.go 67.30% <100.00%> (-1.22%) ⬇️

@davidbloss
Copy link
Contributor Author

This effort was subsumed by a better approach introduced with this PR

@davidbloss davidbloss closed this Nov 10, 2023
@davidbloss davidbloss deleted the db/consolidate-test-pagination-data branch November 10, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant