consolidate test data in tpl files, DomainInput creates test data #296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
#109
Changelog
Consolidate some hardcoded test data into templates
Add
ParseTemplatedStringWith()
which takes in input data for templates.DomainInput
struct indomain_test.go
and referencedomain_input
template at top oftestdata/templates/domains.tpl
Long term, a polished version of this approach may prove useful for generating test data.
List your changes here
Make a
changie
entry, N/A test only dataTophatting
task test
- all tests pass