Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consolidate test data in tpl files, DomainInput creates test data #296

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

davidbloss
Copy link
Contributor

Issues

#109

Changelog

  • Consolidate some hardcoded test data into templates

  • Add ParseTemplatedStringWith() which takes in input data for templates.

    • This lets us create templated test data based on actual structs. See DomainInput struct in domain_test.go and reference domain_input template at top of testdata/templates/domains.tpl
  • Long term, a polished version of this approach may prove useful for generating test data.

  • List your changes here

  • Make a changie entry, N/A test only data

Tophatting

task test - all tests pass

@davidbloss davidbloss requested review from rocktavious and a user November 9, 2023 15:18
Copy link

codecov bot commented Nov 9, 2023

Codecov Report

Merging #296 (56fda3c) into main (86c3889) will decrease coverage by 0.31%.
Report is 8 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   77.10%   76.80%   -0.31%     
==========================================
  Files          50       50              
  Lines        3307     3307              
==========================================
- Hits         2550     2540      -10     
- Misses        554      564      +10     
  Partials      203      203              

see 1 file with indirect coverage changes

@davidbloss davidbloss merged commit 146302d into main Nov 9, 2023
@davidbloss davidbloss deleted the db/test-data-consolidate branch November 9, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant