MissingPackageResult field in CheckPackageVersionUpdateInput made Nul…

…lable
OpsLevel · Oct 22, 2024 · 0647d86 · 0647d86
1 parent 7833c1d
commit 0647d86
Show file tree

Hide file tree

Showing 5 changed files with 43 additions and 40 deletions.
diff --git a/.changes/unreleased/Bugfix-20241022-093210.yaml b/.changes/unreleased/Bugfix-20241022-093210.yaml
@@ -0,0 +1,3 @@
+kind: Bugfix
+body: 'BREAKING CHANGE: CheckPackageVersionUpdateInput changed to allow MissingPackageResult to be nullable'
+time: 2024-10-22T09:32:10.794966-05:00
diff --git a/input.go b/input.go
diff --git a/new_input.go b/new_input.go
@@ -51,7 +51,7 @@ func NullableString(value *string) *Nullable[string] {
 		return nil
 	}
 	if *value == "" {
-		return NewNull()
+		return NewNull[string]()
 	}
 	return NewNullableFrom(*value)
 }
diff --git a/scalar.go b/scalar.go
@@ -78,7 +78,7 @@ func IsID(value string) bool {
 
 // NullableConstraint defines what types can be nullable - keep separated using the union operator (pipe)
 type NullableConstraint interface {
-	string
+	~string
 }
 
 // Nullable can be used to unset a value using an OpsLevel input struct type, should always be instantiated using a constructor.

diff --git a/service_test.go b/service_test.go
@@ -351,10 +351,10 @@ func TestUpdateService(t *testing.T) {
 			Input: ol.ServiceUpdateInputV2{
 				Parent:         ol.NewIdentifier(),
 				Id:             ol.NewID("123456789"),
-				Description:    ol.NewNull(),
-				Framework:      ol.NewNull(),
-				TierAlias:      ol.NewNull(),
-				LifecycleAlias: ol.NewNull(),
+				Description:    ol.NewNull[string](),
+				Framework:      ol.NewNull[string](),
+				TierAlias:      ol.NewNull[string](),
+				LifecycleAlias: ol.NewNull[string](),
 			},
 		},
 		{
-Original file line number
+Diff line change
@@ Expand Up / @@ -78,7 +78,7 @@ func IsID(value string) bool { @@
     // NullableConstraint defines what types can be nullable - keep separated using the union operator (pipe)
     type NullableConstraint interface {
-    	string
+    	~string
     }
     // Nullable can be used to unset a value using an OpsLevel input struct type, should always be instantiated using a constructor.
@@ Expand Down @@