Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PTW): clear reg after resp to prevent problem #4098

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cebarobot
Copy link
Member

PTW use reg full_gvpn_reg to generate GPF for out-of-range gpaddr, but this reg is not cleared after PTW response. If the last PTW request got a bad full_gvpn_reg, the gvpn_gpf and guestFault keeps until next PTW request, resulting in the total mess of state machine.

This patch clears full_gvpn_reg at the response of PTW. As PTW could response in two state paths, this patch adds an independent condition to achieve this.

PTW use reg full_gvpn_reg to generate GPF for out-of-range gpaddr, but
this reg is not cleared after PTW response. If the last PTW request got
a bad full_gvpn_reg, the gvpn_gpf and guestFault keeps until next PTW
request, resulting in the total mess of state machine.

This patch clears full_gvpn_reg at the response of PTW. As PTW could
response in two state paths, this patch adds an independent condition to
achieve this.
@XiangShanRobot
Copy link

[Generated by IPC robot]
commit: 0d651ad

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
0d651ad 1.837 0.442 2.640 1.211 2.154 2.142 2.364 0.941 1.402 1.908 3.110 2.554 2.276 3.311

master branch:

commit astar copy_and_run coremark gcc gromacs lbm linux mcf microbench milc namd povray wrf xalancbmk
066ca24 1.834 0.442 2.640 1.211 2.154 2.142 2.364 0.941 1.402 1.908 3.110 2.554 2.276 3.311
6aee9d0 1.837 0.442 2.640 1.211 2.154 2.142 2.364 0.941 1.402 1.908 3.110 2.554 2.276 3.311
75ed9f4 1.837 0.442 2.640 1.211 2.154 2.142 2.364 0.941 1.399 1.908 3.110 2.554 2.276 3.311
748214a 1.834 0.442 2.640 1.211 2.154 2.142 2.364 0.941 1.402 1.908 3.110 2.551 2.276 3.311
4863970 1.811 0.442 2.640 1.211 2.154 2.143 2.363 0.952 1.402 1.908 3.110 2.555 2.278 3.311

@cebarobot cebarobot marked this pull request as draft December 28, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants