Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LUA] Use xr_new for script debug entities in stack #1769

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Neloreck
Copy link
Contributor

Fixing issue with segfault when executing scripts from game console.
Simple 'spawn_items' script execution throws exceptions from destructor and point to implementation of memory management methods. I suspect that overloaded deletion/allocation methods should be used in pair to prevent crashes --- need confirmation here.

Changes

  • Using xr_new instead of new for stack entities memory allocation

@Xottab-DUTY Xottab-DUTY added Bug The issue in the run-time. Modmaker Experience Modmaker experience with OpenXRay labels Jan 13, 2025
@Xottab-DUTY
Copy link
Member

Do you know, if this is somehow fixes #592?
Could you also look at that issue too, if it's not too much trouble?

@Xottab-DUTY Xottab-DUTY merged commit 691add8 into OpenXRay:dev Jan 13, 2025
28 of 31 checks passed
@Neloreck Neloreck deleted the dev-script-execution-segfault branch January 13, 2025 19:22
@Neloreck
Copy link
Contributor Author

@Xottab-DUTY Will check, investigating garbage in lua VM stack when enabling profiling hooks (call hooks specifically)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug The issue in the run-time. Modmaker Experience Modmaker experience with OpenXRay
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants