CMake refactoring #1535
Merged
CMake refactoring #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Renderer
AI
Masterkatze
force-pushed
the
cmake
branch
6 times, most recently
from
222fac4 to
bf43070
Compare
Xottab-DUTY
previously requested changes
Nov 29, 2023
There was a problem hiding this comment.
@Masterkatze, please, fix compilation with smart_cast enabled (without PURE_DYNAMIC_CAST define). This is really crucial for performance.
Masterkatze
dismissed
Xottab-DUTY’s stale review
PURE_DYNAMIC_CAST was enabled, disabling it will be done in another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.