Feat/sc-31614 #71
Open
Feat/sc-31614 #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ictbeheer
reviewed
Dec 24, 2024
htdocs/wp-content/themes/hollandskroon/src/Commands/PronamicIdealCommand.php
Outdated
Show resolved
Hide resolved
mvdhoek1
reviewed
Dec 27, 2024
htdocs/wp-content/themes/hollandskroon/src/Commands/PronamicIdealCommand.php
Outdated
Show resolved
Hide resolved
htdocs/wp-content/themes/hollandskroon/src/Commands/PronamicIdealCommand.php
Outdated
Show resolved
Hide resolved
htdocs/wp-content/themes/hollandskroon/src/Commands/PronamicIdealCommand.php
Outdated
Show resolved
Hide resolved
hnccox-yard
force-pushed
the
feat/sc-31614
branch
4 times, most recently
from
05c949c to
57ddafd
Compare
hnccox-yard
force-pushed
the
feat/sc-31614
branch
from
57ddafd to
623a9ef
Compare
hnccox-yard
force-pushed
the
feat/sc-31614
branch
from
623a9ef to
00f152b
Compare
mvdhoek1
requested changes
Jan 3, 2025
htdocs/wp-content/themes/hollandskroon/src/Commands/PronamicIdealCleanupCommand.php
Show resolved
Hide resolved
htdocs/wp-content/themes/hollandskroon/src/Commands/PronamicIdealCleanupCommand.php
Show resolved
Hide resolved
htdocs/wp-content/themes/hollandskroon/src/Commands/PronamicIdealCleanupCommand.php
Show resolved
Hide resolved
mvdhoek1
approved these changes
Jan 3, 2025
dtakken
requested changes
Jan 3, 2025
| (new HK\Providers\CommandServiceProvider())->boot(); | ||
| } catch (Exception $e) { | ||
| // Log error. | ||
| error_log('Error booting CommandServiceProvider: ' . $e->getMessage()); |
There was a problem hiding this comment.
Dit is denk ik niet wat je wilt. Exceptions vang je alleen af wanneer je de error situatie kunt oplossen waarna je veilig door kunt. Ik zou zeggen: Laat die exception lekker over aan de exception handler van Fusion.
There was a problem hiding this comment.
...en bij gebrek aan Fusion... aan de exception handler van WP.
There was a problem hiding this comment.
Ik zou hem dit geval wel afvangen omdat anders de hele site eruit ligt. Aan de andere kant zie ik de serviceprovider in deze opzet geen exceptie gooien.
De afhandeling zou wel beter in serviceprovider passen.
Wellicht zit hier nog een oplossing in en anders in de package/plugin die Dik aan het maken is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a pronamic:cleanup command to invoke with crontab every day to remove fulfilled payments older than 5 days