-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport] Added form key validation to Contacts form #4610
Open
sreichel
wants to merge
11
commits into
OpenMage:main
Choose a base branch
from
sreichel:back-3146
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addison74
previously approved these changes
Feb 7, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Contacts
Relates to Mage_Contacts
documentation
git
security
Template : base
Relates to base template
Template : rwd
Relates to rwd template
translations
Relates to app/locale
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
form_key
to contacts formdev:
Added very basic cypress check if
form_key
exists in template. More later ....before:
![cypress-first](https://private-user-images.githubusercontent.com/5022236/410655864-ace6e201-64d8-4198-9fb7-346805d247a5.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MjgwNTQsIm5iZiI6MTczOTUyNzc1NCwicGF0aCI6Ii81MDIyMjM2LzQxMDY1NTg2NC1hY2U2ZTIwMS02NGQ4LTQxOTgtOWZiNy0zNDY4MDVkMjQ3YTUuUE5HP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTAwOTE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9OTIyYTY1Y2QyOTZjNDFhYWFhZDM2ZGRhNmQyMzFmNzAxZmU3YzFiNzc3MGJlMGNhYTkxMmIwZDNiMjEyMmIzZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.tWvNFAOYnY0YXd_Zsmv3mdR_NL87SgNMF3m_7W8hPlM)
after:
![cypress-first-after](https://private-user-images.githubusercontent.com/5022236/410659116-690eb1c9-1e64-416c-8308-2e2883db318d.PNG?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MjgwNTQsIm5iZiI6MTczOTUyNzc1NCwicGF0aCI6Ii81MDIyMjM2LzQxMDY1OTExNi02OTBlYjFjOS0xZTY0LTQxNmMtODMwOC0yZTI4ODNkYjMxOGQuUE5HP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMTAwOTE0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZTE3YzhiMTgwNGU5OGRhNjRhNWRhZWFhN2QyMzVhMGRlZDZlYTY2ZDAyNDM4ZGY0YzBkYzE1YTNjZDQxZjI4NyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.OK5gXqd0Qn_-xqZpt6lwjJu9rIqH-o2dvEZVjpLLfRs)
Related Pull Requests