Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Mage_Eav_Model_Attribute_Data_Date and Mage_Core_Controller_Varien_Action date validations and empty value handling #4605

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

massa-man
Copy link
Contributor

Description (*)

Fix to allow clearing the customer DOB in the admin. This PR also fixes some similar issues with other admin controller date management such as Product controller, which does not use a form, but use the _filterDate() and _filterDateTime() helpers in Mage_Core_Controller_Varien_Action, aligning that code with the fixes I did in PR 3752 to the from filters.

Related Pull Requests

Fixed Issues (if relevant)

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@github-actions github-actions bot added Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav labels Feb 5, 2025
Copy link

sonarqubecloud bot commented Feb 5, 2025

@sreichel sreichel added the bug label Feb 10, 2025
@sreichel
Copy link
Contributor

Bug confirmed,

Just did a quick ckeck. To solve the issue it only requieres changes to app/code/core/Mage/Eav/Model/Attribute/Data/Date.php.

Why change app/code/core/Mage/Core/Controller/Varien/Action.php?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Component: Core Relates to Mage_Core Component: Eav Relates to Mage_Eav
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to clear/remove customer DOB via admin console
2 participants