Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont use google.api to load raleway font #4527

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Feb 2, 2025

Description (*)

PR adds possibility to include css from lib, use new lib_css type and replace call to google.fonts api.

<action method="addItem"><type>lib_css</type><name>fonts/raleway/raleway.css</name></action>

Fixed Issues (if relevant)

Questions or comments

The plugin usage is described here: https://github.com/composer/installers?tab=readme-ov-file#should-we-allow-dynamic-package-types-or-paths-no

@github-actions github-actions bot added Template : rwd Relates to rwd template Component: Page Relates to Mage_Page composer Relates to composer.json XML Layout git labels Feb 2, 2025
@sreichel sreichel changed the title Dont use google.api to use raleway font Dont use google.api to load raleway font Feb 2, 2025
Copy link

sonarqubecloud bot commented Feb 2, 2025

@sreichel sreichel marked this pull request as draft February 10, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Page Relates to Mage_Page composer Relates to composer.json git Template : rwd Relates to rwd template XML Layout
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant