Process only required attributes in api/rest/products/
#4517
+134
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
before (blue = useless calls when no prices or urls are required) after |
sreichel
changed the title
api/rest/products/api/rest/products/
15 tasks
theroch
requested changes
Feb 7, 2025
sreichel
commented
Feb 10, 2025
|
@sreichel why did this MR get closed? |
|
Too lazy to add docblocks. (i cant remember aany new method added, where someone requested docblock changes) |
Hanmac
previously approved these changes
Feb 12, 2025
kiatng
previously approved these changes
Feb 14, 2025
Hanmac
approved these changes
Feb 14, 2025
kiatng
approved these changes
Feb 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Using REST api like
https://magento-lts.ddev.site/api/rest/products/ace000loads all product attributes, even if they are not selected in admin REST attributes configuration. Urls are genenated, prices are loaded, ...