Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add recent netty bundle changes #29205

Open
wants to merge 4 commits into
base: integration
Choose a base branch
from
Open

Add recent netty bundle changes #29205

wants to merge 4 commits into from

Conversation

isaacrivriv
Copy link
Member

Fixes #29204

@isaacrivriv isaacrivriv self-assigned this Jul 26, 2024
@isaacrivriv
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_erhOEEtfEe-Hn-AxXEWsJg

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=34bf2b90-5cbf-4a86-b846-f03b189fe703

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=34bf2b90-5cbf-4a86-b846-f03b189fe703 has errors/failures.

@LibbyBot
Copy link

The build isaacrivriv-29205-20240726-0906
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_erhOEEtfEe-Hn-AxXEWsJg
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_erhOEEtfEe-Hn-AxXEWsJg

@isaacrivriv
Copy link
Member Author

Hit just one issue with a revert so this should be good to merge.

@isaacrivriv isaacrivriv requested a review from pnicolucci July 29, 2024 17:16
epj
epj reviewed Aug 5, 2024
View reviewed changes
dev/io.openliberty.netty.internal/src/io/openliberty/netty/internal/NettyFramework.java Outdated
@@ -13,6 +13,7 @@
import java.util.Set;
import java.util.concurrent.Callable;
import java.util.concurrent.FutureTask;
import java.util.concurrent.atomic.AtomicBoolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed here? I don't see it referenced.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this, I think it's a leftover reference. I'll remove this

@LibbyBot
Copy link

Code analysis and actions

DO NOT DELETE THIS COMMENT.
  • 9 product code files were changed.
  • Please describe in a separate comment how you tested your changes.

@isaacrivriv
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=756a89f4-12f4-4c14-afbc-c6c5af55e486

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Yp790GCiEe-4wdAm7liz3w

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=756a89f4-12f4-4c14-afbc-c6c5af55e486 has errors/failures.

@LibbyBot
Copy link

The build isaacrivriv-29205-20240822-1725
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_Yp790GCiEe-4wdAm7liz3w
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_Yp790GCiEe-4wdAm7liz3w

@isaacrivriv
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d8b2c3ac-b955-4974-ad9a-6c84faaabdb9

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_N7pLMHEhEe-0ZL4JeBVc2g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=d8b2c3ac-b955-4974-ad9a-6c84faaabdb9 has errors/failures.

@isaacrivriv
Copy link
Member Author

#build

@LibbyBot
Copy link

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=081ff205-0633-442f-813c-063a61208329

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_BE6cwHJHEe-0ZL4JeBVc2g

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=081ff205-0633-442f-813c-063a61208329 has errors/failures.

@LibbyBot
Copy link

The build isaacrivriv-29205-20240913-2120
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_BE6cwHJHEe-0ZL4JeBVc2g
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_BE6cwHJHEe-0ZL4JeBVc2g

epj
epj approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@epj epj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the last builds had unrelated errors. I have no further comments.

@isaacrivriv
Copy link
Member Author

#build

@LibbyBot
Copy link

LibbyBot commented Oct 3, 2024

Your personal pipeline request is at https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8406b75a-ca0a-4cd1-a8a1-b75db49dde5a

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Oct 3, 2024

Your personal build request is at https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_i3MtcYGbEe-TieZHY4j0Qw

Target locations of links might be accessible only to IBM employees.

@LibbyBot
Copy link

LibbyBot commented Oct 3, 2024

https://libh-proxy1.fyre.ibm.com/cognitive/pipelineAnalysis.html?uuid=8406b75a-ca0a-4cd1-a8a1-b75db49dde5a has errors/failures.

@LibbyBot
Copy link

LibbyBot commented Oct 4, 2024

The build isaacrivriv-29205-20241003-1629
https://wasrtc.hursley.ibm.com:9443/jazz/resource/itemOid/com.ibm.team.build.BuildResult/_i3MtcYGbEe-TieZHY4j0Qw
completed and has errors or failures.

For help analyzing your personal build, go to https://libh-proxy1.fyre.ibm.com/cognitive/buildAnalysis.html?uuid=_i3MtcYGbEe-TieZHY4j0Qw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epj epj epj approved these changes

@pnicolucci pnicolucci Awaiting requested review from pnicolucci

Assignees

@isaacrivriv isaacrivriv

Labels
CLA Signed in:Transport team:Sirius
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Netty bundle
3 participants
@isaacrivriv @LibbyBot @epj