Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create docker publish action #108

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

quartje
Copy link
Contributor

@quartje quartje commented Nov 16, 2023

This action will create a test image and push it to the GH container registry. It uses a GH action created by ourselves. See: https://github.com/OpenConext/build-and-publish-test-container

@quartje quartje requested review from MKodde and pmeulen November 16, 2023 20:09
@quartje quartje changed the base branch from main to feature/rejuvination November 16, 2023 20:09
Copy link
Member

@MKodde MKodde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @quartje

uses: actions/checkout@v3

- name: Build the app
uses: openconext/build-and-publish-test-container/php82-node20@main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️‍🔥

.github/workflows/build-push-test-docker-image.yml Outdated Show resolved Hide resolved
@MKodde MKodde force-pushed the feature/rejuvination branch from d679648 to 37d72c8 Compare November 29, 2023 14:39
@quartje quartje force-pushed the feature/create_docker_publish_action branch 8 times, most recently from 56395cd to 81844e6 Compare December 7, 2023 14:51
@MKodde MKodde force-pushed the feature/rejuvination branch 8 times, most recently from 4590b1b to cd00335 Compare December 19, 2023 08:33
@quartje quartje force-pushed the feature/create_docker_publish_action branch 2 times, most recently from d6ad863 to 7c48465 Compare January 9, 2024 16:42
Base automatically changed from feature/rejuvination to main January 10, 2024 14:36
@MKodde MKodde force-pushed the feature/create_docker_publish_action branch from 7c48465 to a66e04b Compare January 10, 2024 14:37
@MKodde MKodde merged commit 02f8f31 into main Jan 31, 2024
3 checks passed
@MKodde MKodde deleted the feature/create_docker_publish_action branch January 31, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants