-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend] now also send event_id for events sent to worker coming from stream (#9824) #9791
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9791 +/- ##
=======================================
Coverage 65.24% 65.24%
=======================================
Files 630 630
Lines 60411 60421 +10
Branches 6783 6787 +4
=======================================
+ Hits 39413 39423 +10
Misses 20998 20998 ☔ View full report in Codecov by Sentry. |
@@ -57,4 +57,5 @@ interface AuthContext { | |||
tracing: TracingContext | |||
user: AuthUser | undefined | |||
draft_context?: string | undefined | |||
eventId?: string | undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other fields seem to be snake case, why not this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and in the other files you changed event_id is snake case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a field that existed already in AuthContext, it has been declared here for typing (it was only used in js files)
9313aea
to
1d30541
Compare
Proposed changes
Related issues
Checklist
Further comments