Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brazilianian/abuse ssl/remove unused variable #3203

Closed
wants to merge 3,076 commits into from
Closed

Brazilianian/abuse ssl/remove unused variable #3203

wants to merge 3,076 commits into from
+194,174 −1,157

Conversation

Brazilianian
Copy link

Proposed changes

Just remove the variable to avoid confusion
Also filled doctrings to remove the warnigns

Related issues

#3194

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

akhanafeer and others added 30 commits September 30, 2024 10:59
@akhanafeer
Remove MSSP name (OpenCTI-Platform#2719)
e7e200d
@renovate
Update dependency pandas to v2.2.3 (OpenCTI-Platform#2724)
3287be8 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency stix-shifter-modules-splunk to v7.1.1 (OpenCTI-Plat…
39b800f 
…form#2726)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency stix-shifter-utils to v7.1.1 (OpenCTI-Platform#2728)
bd61b9c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency boto3 to v1.35.29 (OpenCTI-Platform#2736)
b17d65b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency boto3 to v1.35.30 (OpenCTI-Platform#2738)
be6002e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@bradchiappetta
[greynoise-vuln] Add new GreyNoise Vulnerability internal enrichment …
749a3b6 
…connector (v2) (OpenCTI-Platform#2708)
@uTomasAnderson
[Group-IB Connector] bug fixes, code updates, ttl + Improvements (issue
ec09b95 
OpenCTI-Platform#2623) (OpenCTI-Platform#2741)
@brett-fitz
[Threatfox] fixed threatfox doc (OpenCTI-Platform#2739)
c7fbe70
@helene-nguyen @romain-filigran
[Crowdstrike] Improve connector and indicators ingestion (OpenCTI-Pla…
f738026 
…tform#2742)(issue OpenCTI-Platform#2683)

Co-authored-by: Romain Guignard <[email protected]>
@renovate
Update dependency pycti to v6.3.4 (OpenCTI-Platform#2744)
de589ca 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency boto3 to v1.35.31 (OpenCTI-Platform#2745)
b2ca16d 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@helene-nguyen
[Greynoise Vuln] Add greynoise-vuln enrichment connector in CI/CD (Op…
9a19f15 
…enCTI-Platform#2743)
@romain-filigran
[CISA KEV]: Do not republish all the content at each execution (OpenC…
19c7475 
…TI-Platform#2737)(issue OpenCTI-Platform#2720)
@renovate
Update dependency boto3 to v1.35.32 (OpenCTI-Platform#2752)
a17eefa 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@helene-nguyen @romain-filigran
[Recorded Future] RF Integrate the code for Alerts and Playbook Alert…
2924416 
…s into the connector (OpenCTI-Platform#2758)(issue OpenCTI-Platform#2574)

Co-authored-by: Romain Guignard <[email protected]>
@renovate
Update dependency boto3 to v1.35.33 (OpenCTI-Platform#2757)
e8e12a5 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Filigran-Automation
[all] Release 6.3.5
2eaf12d
@renovate
Update opencti/connector-greynoise-vuln Docker tag to v6.3.5 (OpenCTI…
6d95cfe 
…-Platform#2762)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@DNRRomero
[zerofox] fix ordering in intelligence collector (OpenCTI-Platform#2751)
6f59162
@renovate
Update dependency boto3 to v1.35.34 (OpenCTI-Platform#2763)
b3c6c4b 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency boto3 to v1.35.35 (OpenCTI-Platform#2771)
2ce26b7 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency google-api-python-client to v2.148.0 (OpenCTI-Platf…
1d8a2f6 
…orm#2770)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency boto3 to v1.35.36 (OpenCTI-Platform#2774)
023dcae 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@richard-julien
[ransomwarelive] Create predictive ids to prevent stix ids location e…
d6a113b 
…xplosion (issue OpenCTI-Platform#2768) (OpenCTI-Platform#2769)
@Megafredo
[importExternalReference] Bypasses certain security measures when gen…
a35ab39 
…erating a PDF or MD (OpenCTI-Platform#2761)
@Megafredo
[VirusTotal] Fix TypeError: can only concatenate str (not NoneType) t…
19caa30 
…o str (OpenCTI-Platform#2766)
@renovate
Update dependency google-api-core to v2.21.0 (OpenCTI-Platform#2776)
98db247 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@SamuelHassine
[crowdstrike] Fix STIX IDs accumulation, start time and stop time on …
732873b 
…several relations (OpenCTI-Platform#2779)
@Powlinett
[Sentinel] Split former Sentinel connector into two new connectors (e…
b5db367 
…xternal import and stream) (OpenCTI-Platform#2749)
renovate bot and others added 13 commits December 24, 2024 09:46
@renovate
Update dependency boto3 to v1.35.87 (OpenCTI-Platform#3185)
6eb8697 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@helene-nguyen
[Recorded Future] Handle properly incident ID generation and created …
6825e8c 
…and updated dates + correct markdown format (OpenCTI-Platform#3168, OpenCTI-Platform#3169)
@romain-filigran
VirusTotal Livehunt Notifications plyara - no attribute logger (OpenC…
b8ae7a0 
…TI-Platform#3172)
@romain-filigran @helene-nguyen
Update HarfangLab config.yml.sample (OpenCTI-Platform#3188)
d16517b 
Co-authored-by: Helene Nguyen <[email protected]>
@flavienSindou
[HARFANGLAB INCIDENTS] - Unsafe Alert Process attributes access when …
d04a40a 
…creating File (OpenCTI-Platform#3153)
@flavienSindou
[ALL] - Renovate pydantic version >= 2.8.2 (OpenCTI-Platform#3189)
6272220
@renovate @flavienSindou
Update dependency prometheus-client to <= 0.21.1 (OpenCTI-Platform#3193)
1805aac 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: FlavienSindou <[email protected]>
@renovate @flavienSindou
Update dependency pydantic to < 3.0.0 (OpenCTI-Platform#3191)
3dfa9d9 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: FlavienSindou <[email protected]>
@renovate
Update dependency weasyprint to v63 (OpenCTI-Platform#3199)
b3961ae 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate
Update dependency google-auth to v2.37.0 (OpenCTI-Platform#3196)
357e6f3 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Brazilianian
fix: remove useless variable update_existing_data
886b37d
@Brazilianian
feat: fill missed docstring
e398463
@Brazilianian
refactor: run pre-commit
4c916c7
@romain-filigran romain-filigran added the community use to identify PR from community label Dec 27, 2024
@romain-filigran
Copy link
Member

Hello @Brazilianian : Thanks for your contribution.
In order to merge your PR, could you fix the problem with the lint verification ?
Capture d'écran 2025-01-03 120458

@Brazilianian
Copy link
Author

@romain-filigran Sure!

@romain-filigran
Copy link
Member

Checking the connector, it seems that the default CSV feed has been obsolete since the beginning of the year?
@Brazilianian : Do you have the same observation?

@Brazilianian
Copy link
Author

@romain-filigran

Yes, it looks like they closed both formats of ip feed:
.txt - Last updated: 2025-01-02 01:09:06 UTC
.csv - Last updated: 2025-01-03 11:30:00 UTC

I didnt find any articles or posts in social media about it

@helene-nguyen
Copy link
Member

@Brazilianian Thanks for your contribution! Could you sign your commits ? :)

@romain-filigran romain-filigran added this to the PRs backlog milestone Jan 7, 2025
@Brazilianian
Copy link
Author

@helene-nguyen
Yes, sure
I'm sorry for the wait

helene-nguyen
helene-nguyen requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@helene-nguyen helene-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Brazilianian All commits need to signed, could you do that please ? :)

@Brazilianian Brazilianian force-pushed the brazilianian/abuse_ssl/remove_unused_variable branch from 2560c1b to abfd145 Compare January 9, 2025 18:04
@Brazilianian Brazilianian deleted the brazilianian/abuse_ssl/remove_unused_variable branch January 9, 2025 18:07
@Brazilianian Brazilianian mentioned this pull request Jan 9, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helene-nguyen helene-nguyen helene-nguyen requested changes

Assignees
No one assigned
Labels
community use to identify PR from community
Projects
None yet
Milestone
PRs backlog
Development

Successfully merging this pull request may close these issues.