Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ThreatMatch] Added Beautifulsoup parsing and cleaned up code #3047

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pietrocapece
Copy link
Contributor

Proposed changes

  • Added HTML parsing of the content of alerts with Beautifulsoup
  • Removed some legacy code that was commented out

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the community use to identify PR from community label Dec 5, 2024
@flavienSindou flavienSindou changed the title Added Beautifulsoup parsing and cleaned up code [ThreatMatch] Added Beautifulsoup parsing and cleaned up code Dec 24, 2024
@flavienSindou flavienSindou added partner used to identify PR from patner and removed community use to identify PR from community labels Dec 24, 2024
@flavienSindou flavienSindou self-requested a review December 24, 2024 13:46
@flavienSindou
Copy link
Contributor

@pietrocapece Thank you for the feature addition and for cleaning up the code!

I noticed that the requirements file needs to be updated to resolve the merge conflict. Once that's done, I’ll be happy to approve your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
partner used to identify PR from patner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants