-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic implementation of WeightedCrossEntropy torchmetric. #1
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,6 +12,7 @@ dependencies: | |
- pytorch-cuda=12.1 | ||
- pip: | ||
- causal-conv1d==1.1.3.post1 | ||
- mosaicml | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's remove this re: https://github.com/Open-Athena/mdlm/pull/1/files#r1937418877. It's great that Composer is designed to be decoupled from models like that. Torchtitan is too AFAIK. Lightning is not, and I'm not sure what that means yet for running lightning models like this on other training frameworks yet. Either way, there shouldn't be any need to depend on composer in mdlm. |
||
- datasets==2.18.0 | ||
- einops==0.7.0 | ||
- fsspec==2024.2.0 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a better approach for this would be to subclass
torchmetrics.Metric
directly since it would then be portable across Lightning, Composer and Torchtitan (at the very least), without needingcomposer
installed. This is also pretty much overriding everythingLanguageCrossEntropy
does, so I see little advantage to it.