Various updates to the decoding pipeline #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eference to the Opus native methods. Pass frameSize to OpusDecoder.cs#Decode
I think you just saved the project |
OoLunar
approved these changes
Jan 13, 2024
OoLunar
added
documentation
OoLunar
pushed a commit
that referenced
this pull request
May 24, 2024
* Hold decoder state pointer internally to resolve passing an invalid reference to the Opus native methods. Pass frameSize to OpusDecoder.cs#Decode * Ensure address string is null terminated * Handle RTP header extensions * Only operate on voice data, not the entirety of the rented buffer * Account for PCM unit size when allocating PCM buffer * Improved error handling * XML doc for RtpUtilities.cs#GetHeaderExtensionLength
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR targets a few things that were preventing successful audio decoding:
VoiceLinkConnection.csnow ignores RTP header extensions.OpusNativeMethods#Decode, rather than using the number of frames in the buffer.OpusDecoder.csandOpusNativeMethods.Decoder.csto store/return a pointer to the created decoder state, rather than trying to use a pointer to the struct that was originally returned, which was not referring to the created state object.Hopefully this is useful, let me know of any issues 😄.