Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug: Header Link Copying Shows Paragraph Instead of Header Display #122

Closed
wants to merge 0 commits into from

Conversation

PeritusDeveloper
Copy link
Contributor

@PeritusDeveloper PeritusDeveloper commented Apr 4, 2024

Description:

Fixing the minor issue #101 that is on copying header Link it shows paragraph contents instead of the header display
To solve the issue I have added an empty block when user is using fragment navigation website_url#id we will now see the heading and then it's content. Since the navigation bar has height of 56px I chose to use 80px as height for this block.

Issue fixed:

#101

Changes done:

  • changed the index.erb file

Screenshots/Videos

Before Change
image

After Change
image

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • [] Tried squashing the commits into one

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm open to this (the bug bothers me too), but this fix will only work on the one page. Please look into moving the CSS to index.css and documenting what it's there for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants