SignatureHelp and CompletionItem spec fix (#258)

OmniSharp · Jul 9, 2020 · dca32a6 · dca32a6
1 parent d82ff82
commit dca32a6
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 4 deletions.
diff --git a/src/Protocol/Models/CompletionItem.cs b/src/Protocol/Models/CompletionItem.cs
@@ -27,6 +27,7 @@ public class CompletionItem : ICanBeResolved, IRequest<CompletionItem>
         ///
         /// @since 3.15.0
         /// </summary>
+        [Optional]
         public Container<CompletionItemTag> Tags { get; set; }
 
         /// <summary>

diff --git a/src/Protocol/Models/SignatureHelp.cs b/src/Protocol/Models/SignatureHelp.cs
@@ -12,7 +12,7 @@ public class SignatureHelp
         /// <summary>
         /// One or more signatures.
         /// </summary>
-        public Container<SignatureInformation> Signatures { get; set; }
+        public Container<SignatureInformation> Signatures { get; set; } = new Container<SignatureInformation>();
 
         /// <summary>
         /// The active signature.

diff --git a/test/Lsp.Tests/Models/CompletionItemTests_$SimpleTest.json b/test/Lsp.Tests/Models/CompletionItemTests_$SimpleTest.json
@@ -1,7 +1,6 @@
 {
     "label": null,
     "kind": 1,
-    "tags": null,
     "deprecated": false,
     "preselect": false,
     "insertTextFormat": 0,

diff --git a/test/Lsp.Tests/Models/CompletionListTests_$ComplexTest.json b/test/Lsp.Tests/Models/CompletionListTests_$ComplexTest.json
@@ -4,7 +4,6 @@
         {
             "label": null,
             "kind": 7,
-            "tags": null,
             "detail": "details",
             "deprecated": false,
             "preselect": false,

diff --git a/test/Lsp.Tests/Models/CompletionListTests_$SimpleTest.json b/test/Lsp.Tests/Models/CompletionListTests_$SimpleTest.json
@@ -2,7 +2,6 @@
     {
         "label": null,
         "kind": 7,
-        "tags": null,
         "detail": "details",
         "deprecated": false,
         "preselect": false,

diff --git a/test/Lsp.Tests/Models/SignatureHelpTests.cs b/test/Lsp.Tests/Models/SignatureHelpTests.cs
@@ -31,5 +31,17 @@ public void SimpleTest(string expected)
             var deresult = new Serializer(ClientVersion.Lsp3).DeserializeObject<SignatureHelp>(expected);
             deresult.Should().BeEquivalentTo(model);
         }
+
+        [Theory, JsonFixture]
+        public void NoSignaturesTest(string expected)
+        {
+            var model = new SignatureHelp();
+            var result = Fixture.SerializeObject(model);
+
+            result.Should().Be(expected);
+
+            var deresult = new Serializer(ClientVersion.Lsp3).DeserializeObject<SignatureHelp>(expected);
+            deresult.Should().BeEquivalentTo(model);
+        }
     }
 }
diff --git a/test/Lsp.Tests/Models/SignatureHelpTests_$NoSignaturesTest.json b/test/Lsp.Tests/Models/SignatureHelpTests_$NoSignaturesTest.json
@@ -0,0 +1,3 @@
+{
+    "signatures": []
+}