Conversion Bot Message Reaction To Python #1481

Mohammed-MSFT · 2024-12-15T07:05:54Z

No description provided.

Copilot

Copilot reviewed 19 out of 33 changed files in this pull request and generated 3 comments.

Files not reviewed (14)

samples/bot-message-reaction/python/.gitignore: Language not supported
samples/bot-message-reaction/python/.vscode/extensions.json: Language not supported
samples/bot-message-reaction/python/.vscode/launch.json: Language not supported
samples/bot-message-reaction/python/.vscode/settings.json: Language not supported
samples/bot-message-reaction/python/.vscode/tasks.json: Language not supported
samples/bot-message-reaction/python/appManifest/manifest.json: Language not supported
samples/bot-message-reaction/python/assets/sample.json: Language not supported
samples/bot-message-reaction/python/env/.env.local: Language not supported
samples/bot-message-reaction/python/infra/azure.bicep: Language not supported
samples/bot-message-reaction/python/infra/azure.parameters.json: Language not supported
samples/bot-message-reaction/python/requirements.txt: Language not supported
samples/bot-message-reaction/python/config.py: Evaluated as low risk
samples/bot-message-reaction/python/teamsapp.local.yml: Evaluated as low risk
samples/bot-message-reaction/python/teamsapp.yml: Evaluated as low risk

Comments suppressed due to low confidence (5)

samples/bot-message-reaction/python/bots/messageReactionBot.py:47

[nitpick] The error message 'Activity {turn_context.activity.reply_to_id} not found in the log.' could be more descriptive. Consider changing it to 'The activity with ID {turn_context.activity.reply_to_id} was not found in the activity log.'

f"Activity {turn_context.activity.reply_to_id} not found in the log."

samples/bot-message-reaction/python/bots/messageReactionBot.py:69

[nitpick] The error message 'Activity {turn_context.activity.reply_to_id} not found in the log.' could be more descriptive. Consider changing it to 'The activity with ID {turn_context.activity.reply_to_id} was not found in the activity log.'

f"Activity {turn_context.activity.reply_to_id} not found in the log."

samples/bot-message-reaction/python/activity_log.py:13

[nitpick] The error message could be clearer. Consider changing it to 'The activity_id parameter is required for the append method in ActivityLog.'

raise TypeError('activity_id is required for ActivityLog.append')

samples/bot-message-reaction/python/activity_log.py:17

[nitpick] The error message could be clearer. Consider changing it to 'The activity parameter is required for the append method in ActivityLog.'

raise TypeError('activity is required for ActivityLog.append')

samples/bot-message-reaction/python/activity_log.py:29

[nitpick] The error message could be clearer. Consider changing it to 'The activity_id parameter is required for the find method in ActivityLog.'

raise TypeError('activity_id is required for ActivityLog.find')

Copilot · 2025-01-03T10:10:43Z

samples/bot-message-reaction/python/README.md

+- Python
+extensions:
+ contentType: samples
+ createdDate: "12-12-2024 17:00:25"


The date format should be corrected to "2024-12-12T17:00:25Z".

Suggested change

createdDate: "12-12-2024 17:00:25"

createdDate: "2024-12-12T17:00:25Z"

please check other samples readme we were following the same like this
12-12-2024 17:00:25

Copilot · 2025-01-03T10:10:44Z

samples/bot-message-reaction/python/README.md

+ ![Message Reaction](Images/MessageReactions.gif)
+
+ ## Try it yourself - experience the App in your Microsoft Teams client
+Please find below demo manifest which is deployed on Microsoft Azure and you can try it yourself by uploading the app package (.zip file link below) to your teams and/or as a personal app. (Sideloading must be enabled for your tenant, [see steps here](https://docs.microsoft.com/microsoftteams/platform/concepts/build-and-test/prepare-your-o365-tenant#enable-custom-teams-apps-and-turn-on-custom-app-uploading)).


The phrase 'to your teams' should be corrected to 'to your Teams'.

Suggested change

Please find below demo manifest which is deployed on Microsoft Azure and you can try it yourself by uploading the app package (.zip file link below) to your teams and/or as a personal app. (Sideloading must be enabled for your tenant, [see steps here](https://docs.microsoft.com/microsoftteams/platform/concepts/build-and-test/prepare-your-o365-tenant#enable-custom-teams-apps-and-turn-on-custom-app-uploading)).

Please find below demo manifest which is deployed on Microsoft Azure and you can try it yourself by uploading the app package (.zip file link below) to your Teams and/or as a personal app. (Sideloading must be enabled for your tenant, [see steps here](https://docs.microsoft.com/microsoftteams/platform/concepts/build-and-test/prepare-your-o365-tenant#enable-custom-teams-apps-and-turn-on-custom-app-uploading)).

Copilot · 2025-01-03T10:10:44Z

samples/bot-message-reaction/python/README.md

+
+   In the new Azure Bot resource in the Portal, 
+    - Ensure that you've [enabled the Teams Channel](https://learn.microsoft.com/azure/bot-service/channel-connect-teams?view=azure-bot-service-4.0)
+    - In Settings/Configuration/Messaging endpoint, enter the current `https` URL you were given by running the tunneling application. Append with the path `/api/messages`


The phrase 'Append with the path' should be corrected to 'Append it with the path'.

Suggested change

- In Settings/Configuration/Messaging endpoint, enter the current `https` URL you were given by running the tunneling application. Append with the path `/api/messages`

- In Settings/Configuration/Messaging endpoint, enter the current `https` URL you were given by running the tunneling application. Append it with the path `/api/messages`

Pawank-MSFT

please fix the PR comments

Pawank-MSFT · 2025-01-03T10:10:46Z

samples/bot-message-reaction/python/Images/1.InstallApp.png

remove "Python" from app name. please take same app name which we have took for c# or nodejs.

Pawank-MSFT · 2025-01-03T10:18:54Z

samples/bot-message-reaction/python/appManifest/manifest.json

+    "outline": "outline.png"
+  },
+  "name": {
+    "short": "BotMessageReaction Python",


Change app name refer nodejs and c#

Copilot

Copilot reviewed 19 out of 33 changed files in this pull request and generated 2 comments.

Files not reviewed (14)

samples/bot-message-reaction/python/.gitignore: Language not supported
samples/bot-message-reaction/python/.vscode/extensions.json: Language not supported
samples/bot-message-reaction/python/.vscode/launch.json: Language not supported
samples/bot-message-reaction/python/.vscode/settings.json: Language not supported
samples/bot-message-reaction/python/.vscode/tasks.json: Language not supported
samples/bot-message-reaction/python/appManifest/manifest.json: Language not supported
samples/bot-message-reaction/python/assets/sample.json: Language not supported
samples/bot-message-reaction/python/env/.env.local: Language not supported
samples/bot-message-reaction/python/infra/azure.bicep: Language not supported
samples/bot-message-reaction/python/infra/azure.parameters.json: Language not supported
samples/bot-message-reaction/python/requirements.txt: Language not supported
samples/bot-message-reaction/python/teamsapp.yml: Evaluated as low risk
samples/bot-message-reaction/python/bots/init.py: Evaluated as low risk
samples/bot-message-reaction/python/config.py: Evaluated as low risk

Comments suppressed due to low confidence (6)

samples/bot-message-reaction/python/activity_log.py:13

The error message could be more descriptive. Consider changing it to 'activity_id is required for append method in ActivityLog'.

raise TypeError('activity_id is required for ActivityLog.append')

samples/bot-message-reaction/python/activity_log.py:17

The error message could be more descriptive. Consider changing it to 'activity is required for append method in ActivityLog'.

raise TypeError('activity is required for ActivityLog.append')

samples/bot-message-reaction/python/activity_log.py:29

The error message could be more descriptive. Consider changing it to 'activity_id is required for find method in ActivityLog'.

raise TypeError('activity_id is required for ActivityLog.find')

samples/bot-message-reaction/python/activity_log.py:20

[nitpick] The variable name 'obj' is ambiguous. It should be renamed to 'activity_data'.

obj = {activity_id: {"activity": activity}}

samples/bot-message-reaction/python/app.py:19

[nitpick] The import statements should be alphabetically ordered for better readability and maintainability.

from bots import MessageReactionBot

samples/bot-message-reaction/python/app.py:62

[nitpick] The APP_ID generation logic could be simplified by using a ternary operator.

APP_ID = SETTINGS.app_id if SETTINGS.app_id else uuid.uuid4()

Copilot · 2025-01-08T05:42:08Z

samples/bot-message-reaction/python/README.md

+- Python
+extensions:
+ contentType: samples
+ createdDate: "12-12-2024 17:00:25"


The date format in the createdDate field is incorrect. It should be in the format "YYYY-MM-DD".

Suggested change

createdDate: "12-12-2024 17:00:25"

createdDate: "2024-12-12"

Copilot · 2025-01-08T05:42:09Z

samples/bot-message-reaction/python/README.md

+ ## Try it yourself - experience the App in your Microsoft Teams client
+Please find below demo manifest which is deployed on Microsoft Azure and you can try it yourself by uploading the app package (.zip file link below) to your Teams and/or as a personal app. (Sideloading must be enabled for your tenant, [see steps here](https://docs.microsoft.com/microsoftteams/platform/concepts/build-and-test/prepare-your-o365-tenant#enable-custom-teams-apps-and-turn-on-custom-app-uploading)).
+
+**Teams Message Reactions Bot:** [Manifest](/samples/bot-message-reaction/csharp/demo-manifest/bot-message-reaction.zip)


The link to the manifest file points to the C# version instead of the Python version. It should be corrected to avoid confusion.

Suggested change

**Teams Message Reactions Bot:** [Manifest](/samples/bot-message-reaction/csharp/demo-manifest/bot-message-reaction.zip)

**Teams Message Reactions Bot:** [Manifest](/samples/bot-message-reaction/python/demo-manifest/bot-message-reaction.zip)

We have demo manifest in chsarp so we added in nodejs same like this and also following same in python.

Copilot reviewed 19 out of 33 changed files in this pull request and generated no comments.

Files not reviewed (14)

samples/bot-message-reaction/python/.gitignore: Language not supported
samples/bot-message-reaction/python/.vscode/extensions.json: Language not supported
samples/bot-message-reaction/python/.vscode/launch.json: Language not supported
samples/bot-message-reaction/python/.vscode/settings.json: Language not supported
samples/bot-message-reaction/python/.vscode/tasks.json: Language not supported
samples/bot-message-reaction/python/appManifest/manifest.json: Language not supported
samples/bot-message-reaction/python/assets/sample.json: Language not supported
samples/bot-message-reaction/python/env/.env.local: Language not supported
samples/bot-message-reaction/python/infra/azure.bicep: Language not supported
samples/bot-message-reaction/python/infra/azure.parameters.json: Language not supported
samples/bot-message-reaction/python/requirements.txt: Language not supported
samples/bot-message-reaction/python/bots/init.py: Evaluated as low risk
samples/bot-message-reaction/python/app.py: Evaluated as low risk
samples/bot-message-reaction/python/config.py: Evaluated as low risk

Comments suppressed due to low confidence (2)

samples/bot-message-reaction/python/activity_log.py:10

Ensure that the append method is covered by tests, including cases where activity_id or activity is None.

async def append(self, activity_id, activity):

samples/bot-message-reaction/python/activity_log.py:26

Ensure that the find method is covered by tests, including cases where activity_id is None and where the activity is not found.

async def find(self, activity_id):

Mohammed-MSFT added 2 commits December 15, 2024 12:35

Bot Message Reaction Python Sample Added

886be4e

Removed Deployment template folder

f25f9ee

Pawank-MSFT requested a review from Copilot January 3, 2025 10:09

Copilot AI reviewed Jan 3, 2025

View reviewed changes

Pawank-MSFT reviewed Jan 3, 2025

View reviewed changes

Pr Comments Fixed

19b4179

Harikrishnan-MSFT requested a review from Copilot January 8, 2025 05:41

Copilot AI reviewed Jan 8, 2025

View reviewed changes

Harikrishnan-MSFT requested a review from Copilot January 8, 2025 05:44

Copilot AI reviewed Jan 8, 2025

View reviewed changes

PR comments fixed

3d8b3ec

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Conversion Bot Message Reaction To Python #1481

Conversion Bot Message Reaction To Python #1481

Mohammed-MSFT commented Dec 15, 2024

Copilot AI left a comment

Copilot AI Jan 3, 2025

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Mohammed-MSFT Jan 3, 2025

Copilot AI Jan 3, 2025

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Mohammed-MSFT Jan 3, 2025

Copilot AI Jan 3, 2025

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Mohammed-MSFT Jan 3, 2025

Pawank-MSFT left a comment

Pawank-MSFT Jan 3, 2025

Mohammed-MSFT Jan 8, 2025

Pawank-MSFT Jan 3, 2025

Mohammed-MSFT Jan 8, 2025

Copilot AI left a comment

Copilot AI Jan 8, 2025

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Mohammed-MSFT Jan 8, 2025

Copilot AI Jan 8, 2025

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Mohammed-MSFT Jan 8, 2025 •

edited

Loading

	createdDate: "12-12-2024 17:00:25"
	createdDate: "2024-12-12T17:00:25Z"

	- In Settings/Configuration/Messaging endpoint, enter the current `https` URL you were given by running the tunneling application. Append with the path `/api/messages`
	- In Settings/Configuration/Messaging endpoint, enter the current `https` URL you were given by running the tunneling application. Append it with the path `/api/messages`

	Teams Message Reactions Bot: [Manifest](/samples/bot-message-reaction/csharp/demo-manifest/bot-message-reaction.zip)
	Teams Message Reactions Bot: [Manifest](/samples/bot-message-reaction/python/demo-manifest/bot-message-reaction.zip)

Conversion Bot Message Reaction To Python #1481

Are you sure you want to change the base?

Conversion Bot Message Reaction To Python #1481

Conversation

Mohammed-MSFT commented Dec 15, 2024

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Jan 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Copilot AI Jan 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Copilot AI Jan 3, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Pawank-MSFT left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot AI Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Copilot AI Jan 8, 2025

Choose a reason for hiding this comment

Mohammed-MSFT Jan 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mohammed-MSFT Jan 8, 2025 •

edited

Loading