feat: ETH transfers custom native token chains part 1 #2106
+308
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into token-query-params
…e into token-query-params
…ffchainLabs/arbitrum-token-bridge into token-query-params
…-token-bridge into eth-custom-orbit-1
brtkx
commented
Feb 3, 2025
| @@ -48,6 +52,14 @@ function StyledLoader() { | |||
| ) | |||
| } | |||
|
|
|||
| function NativeTokenNetworkText({ chainId }: { chainId: number }) { | |||
There was a problem hiding this comment.
Moved to its own component from this file because it's reused now
brtkx
commented
Feb 3, 2025
| @@ -136,18 +161,24 @@ function TokenListInfo({ token }: { token: ERC20BridgeToken | null }) { | |||
|
|
|||
| interface TokenRowProps { | |||
| style?: React.CSSProperties | |||
| onTokenSelected: (token: ERC20BridgeToken | null) => void | |||
| token: ERC20BridgeToken | null | |||
| onTokenSelected: (parentErc20Address: string | null) => void | |||
There was a problem hiding this comment.
We pass the address to query params anyway, so there's no point passing the entire object. We also don't have to handle different types of token objects for erc20 or native currency, we only pass either address or key.
…e into eth-custom-orbit-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
token=eth, which will indicate that the selected token is ETH. This is becauseselectedToken === nullfor custom native token chains by default indicates that the selected token is the custom native token. This way we can differentiate between the two.useIsSelectedTokenEtherhook, this will return true even ifselectedToken === nullbut token query param istoken=eth.