Skip to content

Commit

Permalink
adding oak-rebuild bin, electron upgrade
Browse files Browse the repository at this point in the history
  • Loading branch information
nucleardreamer committed Aug 1, 2018
1 parent 48824e0 commit 5c0da24
Show file tree
Hide file tree
Showing 12 changed files with 171 additions and 563 deletions.
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
v8.11.3
7 changes: 6 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,12 @@ WORKDIR /
ENTRYPOINT ["oak"]
CMD ["--help"]

ENV NODE_ENV=production \
ENV npm_config_target=1.8.7 \
npm_config_runtime=electron \
npm_config_arch=x64 \
npm_config_target_arch=x64 \
npm_config_disturl=https://atom.io/download/electron \
NODE_ENV=production \
ELECTRON_VERSION=1.8.7 \
DISPLAY=:0 \
DEBUG=false \
Expand Down
7 changes: 6 additions & 1 deletion Dockerfile.template
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,12 @@ WORKDIR /
ENTRYPOINT ["oak"]
CMD ["--help"]

ENV NODE_ENV=production \
ENV npm_config_target=%%ELECTRON_VERSION%% \
npm_config_runtime=electron \
npm_config_arch=x64 \
npm_config_target_arch=x64 \
npm_config_disturl=https://atom.io/download/electron \
NODE_ENV=production \
ELECTRON_VERSION=%%ELECTRON_VERSION%% \
DISPLAY=:0 \
DEBUG=false \
Expand Down
20 changes: 20 additions & 0 deletions bin/rebuild
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
#!/bin/bash -e

echo ""
echo "Rebuilding node modules at $1"
echo ""

ELECTRON_VERSION=${ELECTRON_VERSION:=$(oak version electron)}

pushd $1
export npm_config_target=$ELECTRON_VERSION
export npm_config_runtime=electron
export npm_config_arch=x64
export npm_config_target_arch=x64
export npm_config_disturl=https://atom.io/download/electron

npm rebuild
popd

echo ""
echo "Finished rebuilding native modules"
2 changes: 1 addition & 1 deletion docker-build.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash -e

OAK_VERSION="4.2.4";
OAK_VERSION="4.3.0";
BASE="oaklabs/oak:$OAK_VERSION";

# our FROM line in the Dockerfile, should ideally match the current electron node version
Expand Down
2 changes: 1 addition & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ services:
oak:
build: .
container_name: oak
image: oaklabs/oak:4.2.4
image: oaklabs/oak:4.3.0
network_mode: host
devices:
# our video card device, may vary per operating system
Expand Down
2 changes: 1 addition & 1 deletion examples/multiple-windows/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM oaklabs/oak:4.2.4
FROM oaklabs/oak:4.3.0

WORKDIR /app
COPY . /app
Expand Down
2 changes: 1 addition & 1 deletion examples/simple-url/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM oaklabs/oak:4.2.4
FROM oaklabs/oak:4.3.0

WORKDIR /app
COPY . /app
Expand Down
8 changes: 4 additions & 4 deletions manifest.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
image: oaklabs/oak:4.2.4
image: oaklabs/oak:4.3.0
manifests:
# - image: oaklabs/oak:4.2.4-arm
# - image: oaklabs/oak:4.3.0-arm
# platform:
# architecture: arm
# os: linux
# - image: oaklabs/oak:4.2.4-arm64
# - image: oaklabs/oak:4.3.0-arm64
# platform:
# architecture: arm64
# os: linux
- image: oaklabs/oak:4.2.4-amd64
- image: oaklabs/oak:4.3.0-amd64
platform:
architecture: amd64
os: linux
Loading

0 comments on commit 5c0da24

Please sign in to comment.