Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker-Multi Stage Build #770

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Dishant1804
Copy link
Collaborator

Resolves #734

Modified Dockerfiles that previously lacked support for multi-stage builds, now the necessary files support mullti-stage builds

@github-actions github-actions bot added backend frontend docker Pull requests that update Docker code makefile labels Feb 7, 2025

COPY --from=builder /home/owasp /home/owasp

CMD ["/bin/bash", "-c", "VENV_DIR=$(ls -d /home/owasp/.cache/pypoetry/virtualenvs/*) && $VENV_DIR/bin/pytest"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arkid15r i've noticed that the ci/cd backend test is failing because i have removed the command of poetry run test from the test-backend command in backend/makefile and added the command in the the file it self, please help me out with this, should i modify the ci-cd.yml file in this case?
The same goes with frontend

@yashgoyal0110
Copy link
Contributor

@Dishant1804
Just wanted to know, have you compared build size and build time after making changes?

@yashgoyal0110
Copy link
Contributor

@Dishant1804 any update on this, are you still looking into it?

@Dishant1804
Copy link
Collaborator Author

@yashgoyal0110 let @arkid15r reply with the correct approach with the ci/cd failure that is happening, then i am more than happy to share the metrics, also i was busy for couple of days as we have personal lives too. I would kindly request you to please have a bit patience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend docker Pull requests that update Docker code frontend makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement docker multi-stage build
2 participants