Update spack_cpu_build.yaml to not checkout in base image build step #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pelesh
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Everything seems to work fine.
@cameronrutherford, could you please explain why this change? Just to document it for posterity ;).
|
We already clone the repo in the matrix of jobs in line 83 of the updated file, and so this clone step I remove is unecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In debugging LLNL/hiop#695, I realised that the clone happens at multiple steps in the pipelines, and doesn't need to.
By not cloning when building the base image, we speed up the initial builds a little. We could also kick off the base image pipeline in a separate workflow, and it would surely complete in time for a full spack build (the spack job only needs it to upload to the remote registry.
There's a potential race condition with that if the spack pipeline fails quickly... so I don't see a need to do that.