Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versal2: add documentation #259

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Akshay-Belsare
Copy link

Add documentation for AMD Versal Gen 2 platform.

Add documentation for AMD Versal Gen 2 platform.

Signed-off-by: Akshay Belsare <[email protected]>
Signed-off-by: Amey Avinash Raghatate <[email protected]>

$ cd build
$ make toolchains
$ make all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding -j$(nproc) can speed up the build quite a bit so I recommend adding it. And all is the default target so it does not need to be specified. So I suggest: make -j$(nproc)


Supported boards
****************
AMD Versal Gen 2 adaptive SoCs combine world-class programmable logic from AMD with a new high-performance processing system of integrated Arm CPU.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very useful in this (technical) documentation. Instead, please mention (or link to) which board precisely are supported. Readers should be able to know which board model to purchase if they want to run OP-TEE.

****************
AMD Versal Gen 2 adaptive SoCs combine world-class programmable logic from AMD with a new high-performance processing system of integrated Arm CPU.

Stay tuned for more updates!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove


$ cd ../out/bin/

Stay tuned for more updates!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

.. code-block:: bash

$ cd ../out/bin/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add some instructions on how to obtain any extra firmware binary(ies) and flash the firmware onto the board?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jforissier
discussed few things with @jenswi-linaro separately for this. Updating the change accordingly.

@jbech-linaro
Copy link
Contributor

@Akshay-Belsare , there are a few pending comments from @jforissier . Can you please have a look at them? As soon as it has been addressed, I'd like to merge this.

Updating information about AMD Versal Gen 2.

Signed-off-by: Akshay Belsare <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants