-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versal2: add documentation #259
base: master
Are you sure you want to change the base?
Conversation
Add documentation for AMD Versal Gen 2 platform. Signed-off-by: Akshay Belsare <[email protected]> Signed-off-by: Amey Avinash Raghatate <[email protected]>
building/devices/versal2.rst
Outdated
|
||
$ cd build | ||
$ make toolchains | ||
$ make all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding -j$(nproc)
can speed up the build quite a bit so I recommend adding it. And all
is the default target so it does not need to be specified. So I suggest: make -j$(nproc)
building/devices/versal2.rst
Outdated
|
||
Supported boards | ||
**************** | ||
AMD Versal Gen 2 adaptive SoCs combine world-class programmable logic from AMD with a new high-performance processing system of integrated Arm CPU. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very useful in this (technical) documentation. Instead, please mention (or link to) which board precisely are supported. Readers should be able to know which board model to purchase if they want to run OP-TEE.
building/devices/versal2.rst
Outdated
**************** | ||
AMD Versal Gen 2 adaptive SoCs combine world-class programmable logic from AMD with a new high-performance processing system of integrated Arm CPU. | ||
|
||
Stay tuned for more updates! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
building/devices/versal2.rst
Outdated
|
||
$ cd ../out/bin/ | ||
|
||
Stay tuned for more updates! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove
building/devices/versal2.rst
Outdated
.. code-block:: bash | ||
|
||
$ cd ../out/bin/ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add some instructions on how to obtain any extra firmware binary(ies) and flash the firmware onto the board?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jforissier
discussed few things with @jenswi-linaro separately for this. Updating the change accordingly.
@Akshay-Belsare , there are a few pending comments from @jforissier . Can you please have a look at them? As soon as it has been addressed, I'd like to merge this. |
Updating information about AMD Versal Gen 2. Signed-off-by: Akshay Belsare <[email protected]>
Add documentation for AMD Versal Gen 2 platform.